Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass sizing attribute to determine if responsiveness should be enabled #249

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Pass sizing attribute to determine if responsiveness should be enabled #249

merged 1 commit into from
Jan 17, 2022

Conversation

oscarssanchez
Copy link
Contributor

Description of the Change

This PR fixes responsiveness issues with the Brightcove players. The following players should be now responsive if the user has selected the option:

Video player:

  • Javascript/responsive
  • Iframe/responsive

Playlist player:

  • Iframe/responsive

Video experience player:

  • Javascript/responsive

Playlist experience player:

  • Javascript/responsive

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@oscarssanchez oscarssanchez merged commit 89985b6 into develop Jan 17, 2022
@oscarssanchez oscarssanchez deleted the fix/player-responsiveness branch January 17, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahmon Rahmon Rahmon approved these changes

Assignees

@Rahmon Rahmon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscarssanchez @Rahmon